优化后的代码如下:

/**
 * 创建领导人员+廉洁测评中层民主测评VO.
 *
 * @param midLevelEvaluationParam 中层民主测评参数VO
 * @param excelRowData            Excel行数据
 * @param examineBasicMap         考核基础数据字典
 * @return 领导人员+廉洁测评中层民主测评VO
 */
public MidLevelDemocracyEvaluationVO createLeadersIncorruptibleVO(final MidLevelEvaluationParamVO midLevelEvaluationParam,
                                                                  final Map<Integer, String> excelRowData,
                                                                  final Map<String, ExamineBasicEntity> examineBasicMap) {
    return createMidLevelDemocracyEvaluationVO(midLevelEvaluationParam, excelRowData, examineBasicMap,
        LeadersIncorruptibleExcelHeadTitleEnum.getMidLevelEvaluationDTO(excelRowData));
}

/**
 * 创建领导班子中层民主测评VO.
 *
 * @param midLevelEvaluationParam 中层民主测评参数VO
 * @param excelRowData            Excel行数据
 * @param examineBasicMap         考核基础数据字典
 * @return 领导班子中层民主测评VO
 */
public MidLevelDemocracyEvaluationVO createLeadersTeamVO(final MidLevelEvaluationParamVO midLevelEvaluationParam,
                                                         final Map<Integer, String> excelRowData,
                                                         final Map<String, ExamineBasicEntity> examineBasicMap) {
    return createMidLevelDemocracyEvaluationVO(midLevelEvaluationParam, excelRowData, examineBasicMap,
        LeadersTeamExcelHeadTitleEnum.getMidLevelEvaluationDTO(excelRowData));
}

/**
 * 创建中层民主测评VO.
 *
 * @param midLevelEvaluationParam 中层民主测评参数VO
 * @param excelRowData            Excel行数据
 * @param examineBasicMap         考核基础数据字典
 * @param midLevelEvaluationDTO   中层民主测评DTO
 * @return 中层民主测评VO
 */
private MidLevelDemocracyEvaluationVO createMidLevelDemocracyEvaluationVO(final MidLevelEvaluationParamVO midLevelEvaluationParam,
                                                                          final Map<Integer, String> excelRowData,
                                                                          final Map<String, ExamineBasicEntity> examineBasicMap,
                                                                          final MidLevelEvaluationDTO midLevelEvaluationDTO) {
    final MidLevelDemocracyEvaluationVO midLevelDemocracyEvaluationVO = leaderIncorruptibleEvaluationConvertMapper
        .convertMiddleEvaluationVO(midLevelEvaluationDTO);
    setExaminerAndAppraisee(midLevelEvaluationParam, examineBasicMap, midLevelDemocracyEvaluationVO);
    return midLevelDemocracyEvaluationVO;
}

通过提取一个私有方法createMidLevelDemocracyEvaluationVO,其中包含了公共的部分代码,可以避免重复的代码。同时,将原来的两个方法createLeadersIncorruptibleVOcreateLeadersTeamVO都调用了这个私有方法来创建中层民主测评VO。这样可以提高代码的可读性和可维护性


原文地址: https://www.cveoy.top/t/topic/iJwP 著作权归作者所有。请勿转载和采集!

免费AI点我,无需注册和登录